commit 23af75fc752f703299921b5a4e866a3ac83b5479 from: Roberto E. Vargas Caballero date: Fri Sep 26 17:25:06 2014 UTC Simplify utf8decodebyte using some locals These local variables help to make expressions simpler and avoid use a pointer as induction variable in a for loop. commit - c7a945c4086ab913cd8a05997bfbc1906645eff4 commit + 23af75fc752f703299921b5a4e866a3ac83b5479 blob - 83293f41dbf29024bbf505f7237fa895edf496dd blob + 455f7f41a7de4b620f8457c565d92682b3aed89e --- st.c +++ st.c @@ -453,7 +453,7 @@ static void getbuttoninfo(XEvent *); static void mousereport(XEvent *); static size_t utf8decode(char *, long *, size_t); -static long utf8decodebyte(char, size_t *); +static long utf8decodebyte(uchar, size_t *); static size_t utf8encode(long, char *, size_t); static char utf8encodebyte(long, size_t); static size_t utf8len(char *); @@ -590,11 +590,18 @@ utf8decode(char *c, long *u, size_t clen) { } long -utf8decodebyte(char c, size_t *i) { - for(*i = 0; *i < LEN(utfmask); ++(*i)) - if(((uchar)c & utfmask[*i]) == utfbyte[*i]) - return (uchar)c & ~utfmask[*i]; - return 0; +utf8decodebyte(uchar c, size_t *len) { + size_t i; + long ret = 0; + + for(i = 0; i < LEN(utfmask); ++i) { + if((c & utfmask[i]) == utfbyte[i]) { + ret = c & ~utfmask[i]; + break; + } + } + *len = i; + return ret; } size_t