commit 6521b5dc32d9bdc4d8826324cb7b2877910cc633 from: Roberto E. Vargas Caballero date: Sun Feb 2 18:42:01 2014 UTC Remove non defined behaviour in selcopy It is not defined when lateral effects of expressions are calculated, so an expression as: --last >= gp && !(selected(last - gp, y) is non portable. commit - a8d5870073af14aa08032ab8520c5fe17bb8a1e8 commit + 6521b5dc32d9bdc4d8826324cb7b2877910cc633 blob - c59bf1d64b71771b491f4859a344c15df5b579ea blob + 6e7077af3963f93d96c12aa731754106f778fe3c --- st.c +++ st.c @@ -953,11 +953,12 @@ selcopy(void) { /* append every set & selected glyph to the selection */ for(y = sel.nb.y; y < sel.ne.y + 1; y++) { gp = &term.line[y][0]; - last = gp + term.col; + last = &gp[term.col-1]; - while(--last >= gp && !(selected(last - gp, y) && \ - strcmp(last->c, " ") != 0)) - /* nothing */; + while(last >= gp && !(selected(last - gp, y) && + strcmp(last->c, " ") != 0)) { + --last; + } for(x = 0; gp <= last; x++, ++gp) { if(!selected(x, y) || (gp->mode & ATTR_WDUMMY))