commit a0467c802d4f86ed162486e3453dd61181423902
from: Jochen Sprickerhof <git@jochen.sprickerhof.de>
via: Hiltjo Posthuma <hiltjo@codemadness.org>
date: Mon Dec 27 12:07:11 2021 UTC

Fix null pointer access in strhandle

According to the spec the argument is optional for 104, so p can be
NULL as can be tested with printf '\x1b]104\x07'. This is a regression
of 8e31030.

commit - 273db5ceaf392e68c2faf8f7dec14ea2e25e980d
commit + a0467c802d4f86ed162486e3453dd61181423902
blob - 6783c2b46cc51495e4e02e9079fefd41e7223155
blob + de2dd0ec88c489ac332b223fdef10923198c62d0
--- st.c
+++ st.c
@@ -1960,10 +1960,10 @@ strhandle(void)
 				break;
 			p = strescseq.args[2];
 			/* FALLTHROUGH */
-		case 104: /* color reset, here p = NULL */
+		case 104: /* color reset */
 			j = (narg > 1) ? atoi(strescseq.args[1]) : -1;
 
-			if (!strcmp(p, "?"))
+			if (p && !strcmp(p, "?"))
 				osc4_color_response(j);
 			else if (xsetcolorname(j, p)) {
 				if (par == 104 && narg <= 1)