commit b1e217b29aab8936e9831961943676acd9cdcdd8
from: Adam Purkrt <adam@purkrt.cz>
via: Hiltjo Posthuma <hiltjo@codemadness.org>
date: Mon Mar 17 20:01:05 2025 UTC

XUngrabKeyboard() instead of XUngrabKey()

XUngrabKey(), which is currently used in cleanup(), is not the right
counterpart to XGrabKeyboard(), which is used in grabkeyboard(),
called from main().

XUngrabKeyboard() is the function to use, as grabbing the whole
keyboard is different to grabbing individual keys.

With the current code the keyboard gets ungrabbed, as far as I can tell,
only by the final XCloseDisplay() in cleanup(), as the XUngrabKey()
there effectively does nothing.

commit - 86f0b5119eaa39943013d009967432ffd9d18365
commit + b1e217b29aab8936e9831961943676acd9cdcdd8
blob - 804da6417935b03c29b062a8d75eeb958660d505
blob + fd49549caf05f0329336679236ef124e0e7a1ee4
--- dmenu.c
+++ dmenu.c
@@ -100,7 +100,7 @@ cleanup(void)
 {
 	size_t i;
 
-	XUngrabKey(dpy, AnyKey, AnyModifier, root);
+	XUngrabKeyboard(dpy, CurrentTime);
 	for (i = 0; i < SchemeLast; i++)
 		free(scheme[i]);
 	for (i = 0; items && items[i].text; ++i)