Commits
- Commit:
d39e2f3441fe18aba8d1a62c08918a411ec6f237- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
bump version to 6.3
- Commit:
8657affa2a61e85ca8df76b62e43cb02897d1d80- From:
- Chris Down <chris@chrisdown.name>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
drawbar: Don't expend effort drawing bar if it is occluded
I noticed that a non-trivial amount of dwm's work on my machine was from
drw_text, which seemed weird, because I have the bar disabled and we
only use drw_text as part of bar drawing.
Looking more closely, I realised that while we use m->showbar when
updating the monitor bar margins, but don't skip actually drawing the
bar if it is hidden. This patch skips drawing it entirely if that is the
case.
On my machine, this takes 10% of dwm's on-CPU time, primarily from
restack() and focus().
When the bar is toggled on again, the X server will generate an Expose
event, and we'll redraw the bar as normal as part of expose().
- Commit:
a786211d6cb794fba0ea406d86002c7618998afc- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Revert "Improve speed of drw_text when provided with large strings"
This reverts commit 716233534b35f74dba5a46ade8f1a6f8cc72fea4.
It causes issues with truncation of characters when the text does not fit and
so on. The patch should be reworked and properly tested.
- Commit:
716233534b35f74dba5a46ade8f1a6f8cc72fea4- From:
- Miles Alan <m@milesalan.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Improve speed of drw_text when provided with large strings
Calculates len & ew in drw_font_getexts loop by incrementing instead of
decrementing; as such avoids proportional increase in time spent in loop
based on provided strings size.
- Commit:
138b405f0c8aa24d8a040cc1a1cf6e3eb5a0ebc7- From:
- Quentin Rameau <quinq@fifth.space>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Add a configuration option for fullscreen locking
Some people are annoyed to have this new behaviour forced for some
application which use fake fullscreen.
- Commit:
67d76bdc68102df976177de351f65329d8683064- From:
- Chris Down <chris@chrisdown.name>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Do not allow focus to drift from fullscreen client via focusstack()
It generally doesn't make much sense to allow focusstack() to navigate
away from the selected fullscreen client, as you can't even see which
client you're selecting behind it.
I have had this up for a while on the wiki as a separate patch[0], but
it seems reasonable to avoid this behaviour in dwm mainline, since I'm
struggling to think of any reason to navigate away from a fullscreen
client other than a mistake.
0: https://dwm.suckless.org/patches/alwaysfullscreen/
- Commit:
61bb8b2241d4db08bea4261c82e27cd9797099e7- From:
- Ian Remmler <ian@remmler.org>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Fix x coordinate calculation in buttonpress.
- Commit:
bb2e7222baeec7776930354d0e9f210cc2aaad5f- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
dwm.1: fix wrong text in man page
- Commit:
f04cac6d6e39cd9e3fc4fae526e3d1e8df5e34b2- From:
- Alex Flierl <shad0w73@freenet.de>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Fix memory leaks in drw
The function drw_fontset_free in drw.c was never called.
- Commit:
f09418bbb6651ab4c299cfefbe1d18de401f630e- From:
- bakkeby <bakkeby@gmail.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
dwm crashes when opening 50+ clients (tile layout)
Many users new to dwm find themselves caught out by being kicked out to the login manager (dwm crashing) when they open 50+ clients for demonstration purposes. The number of clients reported varies depending on the resolution of the monitor.
The cause of this is due to how the default tile layout calculates the height of the next client based on the position of the previous client. Because clients have a minimum size the (ty) position can exceed that of the window height, resulting in (m->wh - ty) becoming negative. The negative height stored as an unsigned int results in a very large height ultimately resulting in dwm crashing.
This patch adds safeguards to prevent the ty and my positions from exceeding that of the window height.
- Commit:
ed3ab6b4fceded0e9f2d22372df49a2bbd58de66- From:
- Chris Down <chris@chrisdown.name>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
drawbar: Don't shadow sw global
This jarred me a bit while reading the code, since "sw" usually refers
to the global screen geometry, but in drawbar() only it refers to
text-related geometry. Renaming it makes it more obvious that these are
not related.
- Commit:
f087d20e6e60a49c756936b4312f5d194d8e63b4- From:
- Chris Down <chris@chrisdown.name>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
getatomprop: Add forward declaration
No functional changes, but for every other function we have a forward
declaration here. getatomprop should be no exception.
- Commit:
a8e9513783f335b1ac7255e40a663adfffc4b475- From:
- Chris Down <chris@chrisdown.name>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
setmfact: Unify bounds for compile-time and runtime mfact
There are two places that mfact can be set:
- In the mfact global, which is defined at compile time and passed
into m->mfact during monitor setup. No bounds checks are performed,
but the comment alongside it says that valid values are [0.05..0.95]:
static const float mfact = 0.55; /* factor of master area size [0.05..0.95] */
- By setmfact, which adjusts m->mfact at runtime. It also does some
minimum and maximum bounds checks, allowing [0.1..0.9]. Values outside
of that range are ignored, and mfact is not adjusted.
These different thresholds mean that one cannot setmfact 0.95 or 0.05,
despite the comment above that lists the legal range for mfact.
Clarify this by enforcing the same bounds in setmfact at runtime as
those listed for mfact at compile time.
- Commit:
c82db690cc0c4624dad4dc6ae899020799ec84db- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
config.mk: fix POSIX_C_SOURCE macro for feature test for snprintf()
The feature test was incorrect:
_POSIX_C_SOURCE=2
"The value 2 or greater additionally exposes definitions for POSIX.2-1992."
http://man7.org/linux/man-pages/man7/feature_test_macros.7.html
A higher value is needed (atleast 1995):
https://pubs.opengroup.org/onlinepubs/9699919799/functions/snprintf.html
FreeBSD feature test macro:
on
https://github.com/freebsd/freebsd/blob/master/include/stdio.h line 297
This was already fixed in dmenu.
This fixes a warning on FreeBSD, reported by Plasmoduck on IRC, thanks.
- Commit:
cb3f58ad06993f7ef3a7d8f61468012e2b786cab- From:
- Anselm R Garbe <anselm@garbe.ca>
- Date:
Prepare 6.2 release.
- Commit:
b69c870a3076d78ab595ed1cd4b41cf6b03b2610- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
pledge: add rpath promise for the ugly Xft font fallback
- Commit:
e78b4a9207d92956cee3e5bc3f70b5acabe72e5c- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Makefile: just show the compiler output
Don't be fancy and just show the actual output so debugging is simpler.
- Commit:
3cd4023fb35d0aeb6e888bfdc1845f2f0251ad20- From:
- Klemens Nanni <kn@openbsd.org>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Do not strip at link stage
Building with debug symbols is worthless unless LDFLAGS are manually
adjusted as well.
- Commit:
f40f86fa873bc4acccdf3d929aa0f786993ae31d- From:
- Klemens Nanni <kn@openbsd.org>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Pledge on OpenBSD
- Commit:
c3a2e016bb65c00bd44b6461b1b1bbaa61f20093- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
config.def.h: ClkTagBar missing from comment
by Christopher Drelich <cd@cdrakka.com>
Patch was mangled on the ML, also adjusted the order to be the same as
the enum in dwm.c
- Commit:
c8e9479186dd7e3a0d6dc938369ab3bf7dc4a1d0- From:
- Christopher Drelich <cd@cdrakka.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Function declarations in correct order.
In dwm.c function declarations are in alphabetical order except for
updategeom(). There doesn't appear to be any reason for this, so this
patch corrects that, and now all function declarations are in
alphabetical order.
- Commit:
10dfa65860d770cbce2cdaf67618f44f726a27c3- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
remove old TODO and BUGS entries
the bug in the dwm man page is an (ancient) Java issue.
Thanks David and quinq for the patches and feedback!
- Commit:
3bd8466e93b2c81be86e67c6ecdda4e1d240fe4b- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
update README: remove mentioning the old dextra repo
Thanks Christopher Drelich <cd@cdrakka.com>
- Commit:
76c8c16d79d4fd2a3e776800637d211e4dc8e50a- From:
- Christopher Drelich <cd@cdrakka.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
All functions in alphabetical order except for this one.
- Commit:
3cb34830eb25ebda15a23d8391fd69cddb4fc024- From:
- Christopher Drelich <cd@cdrakka.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
ColBorder has been moved to the enum with ColFg and ColBg.
