Commits
- Commit:
d63b9eb90245926b531bd54b1d591adb96613e70- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
bump version to 0.9.2
- Commit:
497a75638291454875ba1ec8d484c7f3d6f41d66- From:
- DOGMAN <dogman@aaathats3as.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Reset title when an empty title string is given
With this patch, st will reset its window title when an empty string is
given as the terminal title. For example:
printf "\033]0;\007"
Some applications, like termdown, expect this functionality. xterm
implements it, but it seems that most other terminal emulators don't.
In any case, I don't see why there should ever be a case where the st
window doesn't have a title property.
- Commit:
8c68ec52419f3f965164cafcf589b87e8961348d- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Revert "Fix cursor move with wide glyphs"
This reverts commit 7473a8d1a57e5f9aba41b953f4e498c35e1c9dc5.
This patch needs some more work. It caused regressions with programs that use
GNU readline, etc.
Original test-case example from Tim Culverhouse <tim@timculverhouse.com>:
printf " 😀" && sleep 2 && printf "\e[D" && sleep 2 && printf "\e[D" && sleep 2
After the patch it caused regressions, example test-case:
printf "Aå—\bB\n"
- Commit:
5ce971628106fb767ef91bf4386227423f5fdf98- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
bump version to 0.9.1
- Commit:
f20e169a20f3ee761f7e09714f1d4c10916cf4c6- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
config.def.h: improve latency for the default configuration
- Commit:
95f22c53059ccd60ee701ccf2659dacd95e4e89a- From:
- Tommi Hirvola <tommi@hirvola.fi>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
set upper limit for REP escape sequence argument
Previously, printf 'L\033[2147483647b' would call tputc('L') 2^31 times,
making st unresponsive. This commit allows repeating the last character
at most 65535 times in order to prevent freezing and DoS attacks.
- Commit:
7473a8d1a57e5f9aba41b953f4e498c35e1c9dc5- From:
- Quentin Rameau <quinq@fifth.space>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Fix cursor move with wide glyphs
st would always move back 1 column,
even with wide glyhps (using more than a single column).
The glyph rune is set on its first column,
and the other ones are to 0,
so loop until we detect the start of the previous glyph.
- Commit:
a3f7420310be0fd778ef9fe2abf20edc2d8dc81a- From:
- Tim Culverhouse <tim@timculverhouse.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
csi: check for private marker in 'S' case
The handler for 'S' final character does not check for a private
marker. This can cause a conflict with a sequence called 'XTSMGRAPHICS'
which also has an 'S' final character, but uses the private marker '?'.
Without checking for a private marker, st will perform a scroll up
operation when XTSMGRAPHICS is seen, which can cause unexpected display
artifacts.
- Commit:
9846a56bd7fdc86bf788db04bbbcbde7b7eb9952- From:
- Peter Hofmann <scm@uninformativ.de>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Add terminfo entries for bracketed paste mode
Helps Vim (and hopefully others) to discover that this feature exists
without further user configuration.
- Commit:
559fdc278681c98470749adb59f01cd071720458- From:
- Peter Hofmann <scm@uninformativ.de>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Unhide cursor on RIS (\033c)
It is unclear if it's "required" to do this on RIS, but it's useful when
calling reset(1) after interactive programs have crashed and garbled up
the screen.
FWIW, other terminals do it as well (tested with XTerm, VTE, Kitty,
Alacritty, Linux VT).
- Commit:
8abe4bcb41aa7fda0ae00823f6a20271124150db- From:
- Peter Hofmann <scm@uninformativ.de>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Fix wide glyphs breaking "nowrap" mode
Consider the following example:
printf '\e[?7l';\
for i in $(seq $(($(tput cols) - 1))); do printf a; done;\
printf '🙈\n';\
printf '\e[?7h'
Even though MODE_WRAP has been disabled, the emoji appeared on the next
line. This patch keeps wide glyphs on the same line and moves them to
the right-most possible position.
- Commit:
2fc7e532b23e2f820c6b73d352ec7c41fefa45b5- From:
- Peter Hofmann <scm@uninformativ.de>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Don't scroll selection on the other screen
Fixes garbage selections when switching to/from the alternate screen.
How to reproduce:
- Be in primary screen.
- Select something.
- Run this (switches to alternate screen, positions the cursor at the
bottom, triggers selscroll(), and then goes back to primary screen):
tput smcup; tput cup $(tput lines) 0; echo foo; tput rmcup
- Notice how the (visual) selection now covers a different line.
The reason is that selscroll() calls selnormalize() and that cannot find
the original range anymore. It's all empty lines now, so it snaps to
"select the whole line".
- Commit:
a6bbc0c96b0a1db804061b0db79101c6b26aec57- From:
- Peter Hofmann <scm@uninformativ.de>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Fix bounds checks of dc.col
dc.collen is the length of dc.col, not the maximum index, hence if x is
equal to dc.collen, then it's an error.
With config.def.h, the last valid index is 259, so this correctly
reports "black":
$ printf '\033]4;259;?\e\\'
260 is an invalid index and this reports garbage instead of printing an
error:
$ printf '\033]4;260;?\e\\'
- Commit:
eb3b894f4076f2b25afc644a1f444b5cbd96aae8- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Makefile: remove the options target
The Makefile used to suppress output (by using @), so this target made sense at
the time.
But the Makefile should be simple and make debugging with less abstractions or
fancy printing. The Makefile was made verbose and doesn't hide the build
output, so remove this target.
Prompted by a question on the mailing list about the options target.
- Commit:
3a6d6d740110e6ee1b092d05ad746244eedabe4b- From:
- Shi Tian <shitian@cock.li>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Fix for wide character being incorrectly cleared on MODE_INSERT
Under insert mode, when inserting a normal character in front of
a wide character, the affected region is shifted to the right by
one cell. However, the empty cell is reset as if being a part of a
wide character, causing the following cell being mishandled as a
dummy cell.
To reproduce the bug:
printf '\033[4h' # set MODE_INSERT
printf 妳好
printf '\033[4D'
printf 'x'
printf '\033[4l\n'
- Commit:
211964d56ee00a7d46e251cbc150afb79138ae37- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
ignore C1 control characters in UTF-8 mode
Ignore processing and printing C1 control characters in UTF-8 mode.
These are in the range: 0x80 - 0x9f.
By default in st the mode is set to UTF-8.
This matches more the behaviour of xterm with the options -u8 or +u8 also.
Also see the xterm resource "allowC1Printable".
Let me know if this breaks something, in most cases I don't think so.
As usual a very good reference is:
https://invisible-island.net/xterm/ctlseqs/ctlseqs.html
- Commit:
f17abd25b376c292f783062ecf821453eaa9cc4c- From:
- Adam Price <komidore64@gmail.com>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Add support for DSR response "OK" escape sequence
"VT100 defines an escape sequence [1] called Device Status Report (DSR). When
the DSR sequence received is `csi 5n`, an "OK" response `csi 0n` is returned.
This patch adds that "OK" response.
I encountered this missing sequence when I noticed that fzf [2] would clobber
my prompt whenever completing a find.
To test that ST doesn't currently respond to `csi 5n`, use fzf's shell
extension in ST's repo to complete the path for a file.
my-fancy-prompt $ vim **<tab>
<select a file>
st.c
Select a file with <enter>, and notice that fzf clobbers some or all of your
prompt.
After applying this patch, do the same test as above and notice that fzf has no
longer clobbered your prompt by placing the file name in the correct position
in your command.
my-fancy-prompt $ vim **<tab>
<select a file>
my-fancy prompt $ vim st.c
Thank you for considering my first patch submission.
[1] https://www.xfree86.org/current/ctlseqs.html#VT100%20Mode
[2] https://github.com/junegunn/fzf
"
Patch slightly adapted with input from the mailinglist,
- Commit:
7e8050cc621f27002eaf1be8114dee2497beff91- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Fixed OSC color reset without parameter->resets all colors
Adapted from (garbled) patch by wim <wim@thinkerwim.org>
Additional notes: it should reset all the colors using xloadcols().
To reproduce: set a different (theme) color using some escape code, then reset
it:
printf '\x1b]104\x07'
- Commit:
e5e959835b195c023d1f685ef4dbbcfc3b5120b2- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
fix buffer overflow when handling long composed input
To reproduce the issue:
"
If you already have the multi-key enabled on your system, then add this line
to your ~/.XCompose file:
[...]
<question> <T> <E> <S> <T> <question> :
"1234567890123456789012345678901234567890123456789012345678901234567890"
"
Reported by and an initial patch by Andy Gozas <andy@gozas.me>, thanks!
Adapted the patch, for now st (like dmenu) handles a fixed amount of composed
characters, or otherwise ignores it. This is done for simplicity sake.
- Commit:
68d1ad9b54e952e3079356aeab8ab37e44c56c2c- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
bump version to 0.9
- Commit:
00085199039ee63acc7b1ecb7e3774a9c3552b2a- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
FAQ: document the color emojis crash issue which affected some systems is fixed
It is fixed in libXft 2.3.6:
https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS
- Commit:
72fd32736a612edec43596c14148322122a5544d- From:
- Tom Schwindl <schwindl@posteo.de>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
st: use `void' to indicate an empty parameter list
- Commit:
baa9357e96d2478baa52a3301e70ac80a229b726- From:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
Makefile: add manual path for OpenBSD
- Commit:
8629d9a1da72cc18568a8f146307b0e939b77ebf- From:
- NRK <nrk@disroot.org>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
code-golfing: cleanup osc color related code
* adds missing function prototype
* move xgetcolor() prototype to win.h (that's where all the other x.c
func prototype seems to be declared at)
* check for snprintf error/truncation
* reduces code duplication for osc 10/11/12
* unify osc_color_response() and osc4_color_response() into a single function
the latter two was suggested by Quentin Rameau in his patch review on
the hackers list.
- Commit:
ef0551932fb162f907b40185d2f48c3b497708ee- From:
- NRK <nrk@disroot.org>
- Via:
- Hiltjo Posthuma <hiltjo@codemadness.org>
- Date:
base64_digits: reduce scope, implicit zero, +1 size
the array is not accessed outside of base64dec() so it makes sense to
limit it's scope to the related function. the static-storage duration of
the array is kept intact.
this also removes unnecessary explicit zeroing from the start and end of
the array. anything that wasn't explicitly zero-ed will now be
implicitly zero-ed instead.
the validity of the new array can be easily confirmed via running this
trivial loop:
for (int i = 0; i < 255; ++i)
assert(base64_digits[i] == base64_digits_old[i]);
lastly, as pointed out by Roberto, the array needs to have 256 elements
in order to able access it as any unsigned char as an index; the
previous array had 255.
however, this array will only be accessed at indexes which are
isprint() || '=' (see `base64dec_getc()`), so reducing the size of the
array to the highest printable ascii char (127 AFAIK) + 1 might also be
a valid strategy.
